Add a test on Number related locale #9807
Conversation
rommni
requested review from
cboulanger,
derrell,
hkollmann,
johnspackman,
level420 and
oetiker
as code owners
| return; | ||
| } | ||
|
|
||
| var Number = qx.locale.Number; |
There was a problem hiding this comment.
Overwriting the native Number object is certainly legal, but is it a good idea? Maybe use a different symbol?
There was a problem hiding this comment.
@cboulanger: do you mean the name of the test class? It’s not qx.locale.Number, it’s qx.test.locale.Number!
There was a problem hiding this comment.
Ah! Sorry you mean Number! Yes. this should be avoided.
There was a problem hiding this comment.
Hum effectively i took the code from the qx.test.locale.Date, i will change that.
|
I am missing the change of compile.json for the french locale? |
|
@hkollmann after more investigating the change wasn't needed, the fact is that for testing i added the qxl.testtapper package and was running the test with it and this one was compiled using compile.json settings and so was lacking the fr locale, however the framework config settings contains the french locale. |
|
Can you add your testtapper compile.json as compileTest.json? |
|
@hkollmann of course i can, do you want me to push my Manifest.json and qx-lock.json with testtapper add too? Maybe only the qx-lock? Currently i include in compile.json testtapper app only my qx.test.locale.Number class, should i let this or change it? |
|
I suggest a project in testgui from where the testrunner can run. Your test is not working in the python toolchain. With this test project we are able to run the tests with the compiler tool chain. |
|
@hkollmann Do you mean the test breaks the python toolchain (because the tests seem to pass), or it simply doesn't run in the generator-based toolchain. Because if the latter is the case, it doesn't really matter, does it? |
|
It's not running. But i would like to archive the test project as a base for changing the test procedure |
|
sorry a little busy currently, i'll looking that as soon as i have the time ;) |
|
Hi @rommni , any chance you can revisit and finalize this PR? Thank you. |
|
Hi @cboulanger sorry i totally forgotten this one, of course i will look at this (trying to do that in the week) |
|
Just a message to tell i haven't forget this but just not enough time these last days doing that as soon i can |
|
Testing is completely reworked |
|
repos is gone, |
Like discussed on qooxdoo/qooxdoo-compiler#587 add test to number related locale value.
Testing fr locale allow to test that the locale linked to defaultNumberingSystem are loaded and not just the first one declared in cldr files